Golangci-lint

chore: enable golangci-lint on Windows and MacOS #1278

Triggered via pull request January 30, 2025 18:30

mmorel-35

synchronize #1785

mmorel-35:golangci-lint-os-matrix

Status Failure

Total duration 1m 2s

Artifacts –

lint.yml

on: pull_request

Matrix: lint

Annotations

20 errors

lint (windows-latest): load/load_windows.go#L17

var-declaration: should drop = 0.0 from declaration of var loadAvg1M; it is the zero value (revive)

lint (windows-latest): load/load_windows.go#L18

var-declaration: should drop = 0.0 from declaration of var loadAvg5M; it is the zero value (revive)

lint (windows-latest): load/load_windows.go#L19

var-declaration: should drop = 0.0 from declaration of var loadAvg15M; it is the zero value (revive)

lint (windows-latest): load/load_windows.go#L30

var-declaration: should omit type time.Duration from declaration of var samplingFrequency; it will be inferred from the right-hand side (revive)

lint (windows-latest): load/load_windows.go#L31

var-declaration: should omit type float64 from declaration of var loadAvgFactor1M; it will be inferred from the right-hand side (revive)

lint (windows-latest): load/load_windows.go#L32

var-declaration: should omit type float64 from declaration of var loadAvgFactor5M; it will be inferred from the right-hand side (revive)

lint (windows-latest): load/load_windows.go#L33

var-declaration: should omit type float64 from declaration of var loadAvgFactor15M; it will be inferred from the right-hand side (revive)

lint (windows-latest): host/host_windows.go#L82

error-strings: error strings should not be capitalized or end with punctuation or a newline (revive)

lint (windows-latest): internal/common/common_windows.go#L283

superfluous-else: if block ends with a continue statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (revive)

lint (windows-latest): process/process_windows_64bit.go#L41

indent-error-flow: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (revive)

lint (macos-latest): internal/common/common_darwin.go#L370

receiver-naming: receiver name c should be consistent with previous receiver name s for CStr (revive)

lint (macos-latest): internal/common/common_darwin.go#L309

fmt.Errorf can be replaced with errors.New (perfsprint)

lint (macos-latest): internal/common/common_darwin.go#L327

fmt.Errorf can be replaced with errors.New (perfsprint)

lint (macos-latest): internal/common/common_darwin.go#L346

fmt.Errorf can be replaced with errors.New (perfsprint)

lint (macos-latest): mem/mem_darwin_test.go#L16

error-nil: use assert.NoError (testifylint)

lint (macos-latest): mem/mem_darwin_test.go#L19

error-nil: use assert.NoError (testifylint)