Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop the fast path for enableNativeCode == true #19

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chayleaf
Copy link
Contributor

This caused issues when Nix was used as a library, because eval settings are only present in the binary.

For example, Hydra (among other things) errored out like this:

error: could not dynamically open plugin file '"/nix/store/2jr1wzy4ph2pv0h9fzpw1375ywbh6psl-nix-plugins-15.0.0/lib/nix/plugins/libnix-extra-builtins.so"':  /nix/store/2jr1wzy4ph2pv0h9fzpw1375ywbh6psl-nix-plugins-15.0.0/lib/nix/plugins/libnix-extra-builtins.so: undefined symbol: _ZN3nix12evalSettingsE

This causes issues when Nix was used as a library, because eval settings
are only present in the binary.
@shlevy
Copy link
Owner

shlevy commented Jan 31, 2025

Hmm why is there Nix evaluation happening without eval settings? I don’t think we can rely on the evaluator not hitting evalSettings even if nix-plugins avoids it. Seems like a bug in whatever program is driving this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants