Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SG-38064 Python 2 Removal #189

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

SG-38064 Python 2 Removal #189

wants to merge 5 commits into from

Conversation

eduardoChaucaGallegos
Copy link
Contributor

@eduardoChaucaGallegos eduardoChaucaGallegos commented Feb 14, 2025 •
edited
Loading

Description

  • Super format updated.
  • future code removed.
  • six.ensure_str() functions replaced by str().
  • six python version conditional removed.
  • six.moves replaced by native.

Tests

  • Project Configuration
    image

@eduardoChaucaGallegos eduardoChaucaGallegos requested a review from a team February 18, 2025 07:26
carlos-villavicencio-adsk
carlos-villavicencio-adsk approved these changes Feb 18, 2025
View reviewed changes
Copy link
Contributor

@carlos-villavicencio-adsk carlos-villavicencio-adsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

julien-lang
julien-lang approved these changes Feb 18, 2025
View reviewed changes
Copy link
Contributor

@julien-lang julien-lang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julien-lang julien-lang julien-lang approved these changes

@carlos-villavicencio-adsk carlos-villavicencio-adsk carlos-villavicencio-adsk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eduardoChaucaGallegos @julien-lang @carlos-villavicencio-adsk