Include response body in non-200 OK error text. #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitshur
added a commit
to shurcooL/githubv4
that referenced
this pull request
Sep 25, 2018
The error text has changed in commit shurcooL/graphql@e4a3a37 to include response body. Change the test for new behavior. Follows shurcooL/graphql#30.
|
Great advance! It is not covering all the cases that we covered in #24, but I can understand the limitations of guessing if a body with a 4xx status code can be try to be decoded as a graphql valid response. At least the client can see the body response if something went wrong, so the troubleshooting can be improved a lot. |
cjwagner
added a commit
to cjwagner/test-infra
that referenced
this pull request
Sep 25, 2018
k8s-ci-robot
added a commit
to kubernetes/test-infra
that referenced
this pull request
Sep 26, 2018
Update vendored graphql library to include shurcooL/graphql#30.
grihabor
pushed a commit
to grihabor/graphql
that referenced
this pull request
Jul 20, 2022
… for unit tests (shurcooL#30) add debug mode, expose GraphQL builder functions and UnmarshalGraphQL for unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a GraphQL server returns a non-200 OK status code, it may be very helpful to for caller to know what the response body was. So, when such an error occurs, fetch the response body and include it in the returned error text.
Fixes #29.
Updates #24.
/cc @cjwagner @jorgesece @robermorales