Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the behavior of in-memory tables to support multiple '@index' annotations #1491

Merged
merged 1 commit into from
Sep 10, 2019

Conversation

suhothayan
Copy link
Contributor

Purpose

To uniform the behavior of @index annotation of the table.
For more information refer #1228

Release Notes

The behavior of @index annotation of the in-memory table is modified to accept only one index element per annotation. Through this, to use multiple indexes on the table multiple '@index()' annotations should be defined per each index key.

@codecov-io
Copy link

Codecov Report

Merging #1491 into master will decrease coverage by 0.01%.
The diff coverage is 50%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1491      +/-   ##
============================================
- Coverage     68.14%   68.12%   -0.02%     
  Complexity       42       42              
============================================
  Files           643      643              
  Lines         26968    26981      +13     
  Branches       4257     4260       +3     
============================================
+ Hits          18376    18380       +4     
- Misses         6804     6812       +8     
- Partials       1788     1789       +1
Impacted Files Coverage Δ Complexity Δ
...ava/io/siddhi/query/api/util/AnnotationHelper.java 32.5% <0%> (-5.74%) 0 <0> (ø)
...io/siddhi/core/partition/PartitionRuntimeImpl.java 86.63% <100%> (+0.46%) 0 <0> (ø) ⬇️
...va/io/siddhi/core/util/parser/PartitionParser.java 98.41% <100%> (ø) 0 <0> (ø) ⬇️
.../io/siddhi/core/util/parser/EventHolderPasser.java 76.66% <66.66%> (-0.7%) 0 <0> (ø)
...java/io/siddhi/core/stream/input/InputHandler.java 77.41% <0%> (-3.23%) 0% <0%> (ø)
...istence/IncrementalFileSystemPersistenceStore.java 50.96% <0%> (-0.97%) 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 610b58d...70df0d7. Read the comment docs.

@mohanvive mohanvive merged commit 9fc0a76 into siddhi-io:master Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants