Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: display OMNI_ENDPOINT in the service account creation UI #873

Merged
merged 1 commit into from
Jan 29, 2025
Merged

feat: display OMNI_ENDPOINT in the service account creation UI #873

merged 1 commit into from
Jan 29, 2025

Conversation

Unix4ever
Copy link
Member

Fixes: #858

@Unix4ever
Copy link
Member Author

Screenshot 2025-01-23 at 21 32 57

@utkuozdemir
Copy link
Member

Screenshot 2025-01-23 at 21 32 57

does it also have the copy button on top right on hover?

@Unix4ever Unix4ever force-pushed the display-omni-api-endpoint-service-account branch from 2a5adf1 to c00b848 Compare January 23, 2025 14:36
@Unix4ever
Copy link
Member Author

does it also have the copy button on top right on hover?

Yep

@smira
Copy link
Member

smira commented Jan 23, 2025

Should we show a way to set/export these variables as ready-to-use script?

@Unix4ever
Copy link
Member Author

I've tried it but it looked a bit weird.
Nothing stops us from doing that of course

@Unix4ever Unix4ever force-pushed the display-omni-api-endpoint-service-account branch from c00b848 to 7c1ab96 Compare January 23, 2025 15:11
@Unix4ever
Copy link
Member Author

Ok, changed it to show the same stuff as we do in CLI.
Also updated all file headers to have (c) 2025

@Unix4ever Unix4ever force-pushed the display-omni-api-endpoint-service-account branch from 7c1ab96 to c7433ff Compare January 23, 2025 15:14
@Unix4ever
Copy link
Member Author

Screenshot 2025-01-23 at 22 17 47

@utkuozdemir
Copy link
Member

Ok, changed it to show the same stuff as we do in CLI. Also updated all file headers to have (c) 2025

cool, btw, in the CLI output I believe we don't have the export command, but it's a good idea to add it, more handy to copy/paste that way.

utkuozdemir
utkuozdemir approved these changes Jan 24, 2025
View reviewed changes
Copy link
Member

@utkuozdemir utkuozdemir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR breaks my Chrome :) but LGTM

@Unix4ever Unix4ever force-pushed the display-omni-api-endpoint-service-account branch 3 times, most recently from 3f9988c to 5117ba8 Compare January 29, 2025 12:26
@Unix4ever Unix4ever force-pushed the display-omni-api-endpoint-service-account branch from 5117ba8 to ed946b3 Compare January 29, 2025 12:27
@Unix4ever
Copy link
Member Author

/m

@talos-bot talos-bot merged commit ed946b3 into siderolabs:main Jan 29, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@utkuozdemir utkuozdemir utkuozdemir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[feature] Add Omni URL to add service account create screen
4 participants
@Unix4ever @utkuozdemir @smira @talos-bot