Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add Orange Pi 5 Plus support #52

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

feat: add Orange Pi 5 Plus support #52

wants to merge 5 commits into from

Conversation

rpersee
Copy link

@rpersee rpersee commented Jan 30, 2025

Add Orange Pi 5 Plus support.

Fixes: #48

@rpersee rpersee marked this pull request as draft January 30, 2025 23:16
DmitriyMV
DmitriyMV reviewed Feb 2, 2025
View reviewed changes
installers/orangepi-5-plus/src/main.go Outdated Show resolved Hide resolved
installers/orangepi-5-plus/src/main.go Outdated Show resolved Hide resolved
@rpersee
feat: add Orange Pi 5 Plus support
23f04b7 
Add Orange Pi 5 Plus support.

Fixes: siderolabs#48

Signed-off-by: Ryan Persée <[email protected]>
@rpersee
fix(orangepi-5-plus): ethernet support in u-boot
93b60f3 
Enable PCI bus enumeration with CONFIG_PCI_INIT_R Kconfig option:
https://lists.denx.de/pipermail/u-boot/2020-May/412259.html

Signed-off-by: Ryan Persée <[email protected]>
@rpersee
fix: typo in u-bootloader install comments
e2e17a6 
Signed-off-by: Ryan Persée <[email protected]>
@rpersee
refactor: remove redundant var declaration
6d64fac 
file pointer type is infered from the assigned value

Signed-off-by: Ryan Persée <[email protected]>
@rpersee
refactor: simplify return statement in file sync
c53b00c 
Signed-off-by: Ryan Persée <[email protected]>
@rpersee
Copy link
Author

rpersee commented Feb 4, 2025

Hello @DmitriyMV, I've applied your suggestions to all boards.
I still need to test a full install of Talos, but I've flashed u-boot from my PR and can confirm that it can boot my current OS (armbian) and ethernet is now showing in u-boot.
Regarding ethernet, I've only tested pinging other machines, but I plan to test PXE as well.

@frezbo
Copy link
Member

frezbo commented Feb 5, 2025

Hello @DmitriyMV, I've applied your suggestions to all boards. I still need to test a full install of Talos, but I've flashed u-boot from my PR and can confirm that it can boot my current OS (armbian) and ethernet is now showing in u-boot. Regarding ethernet, I've only tested pinging other machines, but I plan to test PXE as well.

let's not do that in this PR, that could be a different One

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DmitriyMV DmitriyMV DmitriyMV left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for Orange Pi 5 Plus (RK3588)
3 participants
@rpersee @frezbo @DmitriyMV