-
-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run Linux arm64 build and tests on native CI runners #61
base: main
Are you sure you want to change the base?
Conversation
Looks like this build is failing at the moment:
https://github.com/signalapp/ringrtc/actions/runs/13048532063/job/36431086293?pr=61 has all of the details, but I'm not sure if they're visible to you. (perhaps this is related to #62 ?) |
@dennisameling Hello! Could you change |
We will make a release soon that should fix the build failure here, and remove dependency on GCC 14.0 because we were using a newer Ubuntu runner. Then this PR can be rebased and squashed on that. |
I actually wonder what the benefit would be here. |
GitHub doesn't currently support using the ubuntu-2x.04-arm runners in private test/development repositories yet, so we need to use an organizational runner for now. |
370a5a7
to
497932e
Compare
@dennisameling Any ideas about the issue running on arm64? We can take a look, but may not be able to get to it right away. Otherwise the PR changes look good so far. Thanks! |
The interesting thing is that I'm not seeing this issue on the GitHub-hosted
So that's another error than the error which is coming from your org-level
Are you using a custom image for your org-level arm64 runner by any chance, or the default one from partner-runner-images? Just trying to understand if there would be any difference at all in the GitHub-hosted OSS arm64 runners vs the custom (but GitHub-hosted) org-level ones. |
Curious, I would have thought that would be fixed by e07256b / by using 22.04 rather than 24.04...
I believe we're using the standard image; it's described as "Ubuntu 22.04 by Arm Limited" |
I also see this:
perhaps we need to switch where we're grabbing the pipewire packages from? |
The runner we are using is based on the same ARM partner-runner-images, just with more memory and storage. It is a mystery then why it would work with the public ones, because they appear to be directly using the partner-runner-images too. |
Interesting. I've just configured an org-level runner on my end as well, and am running into the same issue. So there must be some sort of difference in either the machines or the images that these org-level runners run on. Just created a Support Ticket ( |
GitHub support recommended opening an issue in the |
I just installed an Ubuntu 22.04 arm64 VM and tested this by building locally. I'm seeing the following:
I even compiled WebRTC from scratch for v2.49.5 (from an x64 host), then used that in my build, and got the same error. Interestingly, the same error doesn't show up on Ubuntu 24.04. e07256b at least fixed the I found this Chromium bug report about |
Found another possibly related Chromium issue. They pushed this commit in August to only set I wonder if the team here would be open to try and set I'd be happy to try and build things myself and test on arm64 hardware, but would need to know where to set this flag. I have a feeling that simply adding it to the |
Oh, great find!
Given that the alternative is that the arm64 linux build is broken, I'm inclined to say "yes," but I'm going to discuss with my other team members.
I believe that's the right place, yes. |
Here's a PR that sets |
Thanks @dennisameling, we are trying it out and plan to merge it in. |
I can confirm that the |
In #59 (comment), the following was mentioned:
GitHub now offers hosted Linux arm64 runners, so it's possible to build and test natively on this architecture. This PR updates the CI pipeline accordingly.