Merge pull request #2552 from signalwire/email

andywolk · web-flow · commit c1354fd73be7 · 2024-07-30T19:10:46.000+03:00
[Core] switch_simple_email: Coverity 1227612 Calling risky function
diff --git a/src/switch_utils.c b/src/switch_utils.c
@@ -1160,7 +1160,7 @@ SWITCH_DECLARE(switch_bool_t) switch_simple_email(const char *to,
 		switch_safe_free(dupfile);
 	}
 
-	switch_snprintf(filename, 80, "%s%smail.%d%04x", SWITCH_GLOBAL_dirs.temp_dir, SWITCH_PATH_SEPARATOR, (int)(switch_time_t) switch_epoch_time_now(NULL), rand() & 0xffff);
+	switch_snprintf(filename, 80, "%s%smail.%d%04x", SWITCH_GLOBAL_dirs.temp_dir, SWITCH_PATH_SEPARATOR, (int)(switch_time_t) switch_epoch_time_now(NULL), switch_rand() & 0xffff);
 
 	if ((fd = open(filename, O_WRONLY | O_CREAT | O_TRUNC, 0644)) > -1) {
 		if (file) {

Original file line number	Diff line number	Diff line change
`@@ -1160,7 +1160,7 @@ SWITCH_DECLARE(switch_bool_t) switch_simple_email(const char *to,`
`1160`	`1160`	`switch_safe_free(dupfile);`
`1161`	`1161`	`}`
`1162`	`1162`
`1163`		`- switch_snprintf(filename, 80, "%s%smail.%d%04x", SWITCH_GLOBAL_dirs.temp_dir, SWITCH_PATH_SEPARATOR, (int)(switch_time_t) switch_epoch_time_now(NULL), rand() & 0xffff);`
	`1163`	`+ switch_snprintf(filename, 80, "%s%smail.%d%04x", SWITCH_GLOBAL_dirs.temp_dir, SWITCH_PATH_SEPARATOR, (int)(switch_time_t) switch_epoch_time_now(NULL), switch_rand() & 0xffff);`
`1164`	`1164`
`1165`	`1165`	`if ((fd = open(filename, O_WRONLY \| O_CREAT \| O_TRUNC, 0644)) > -1) {`
`1166`	`1166`	`if (file) {`