Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vc: increase default gas limit #6897

Open
wants to merge 4 commits into
base: unstable
Choose a base branch
from

Conversation

@chong-he chong-he added the ready-for-review The code is ready for review label Feb 3, 2025
@michaelsproul michaelsproul changed the base branch from stable to unstable February 6, 2025 04:33
@michaelsproul michaelsproul added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-review The code is ready for review labels Feb 6, 2025
Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please rebase on unstable? 🙏

I think we also need to change the default gas limit for the CLI interface, as that takes prio over the DEFAULT_GAS_LIMIT constant. The file to edit for that is validator_client/src/cli.rs. You'll also need to rebuild the CLI docs with: make && make cli-local, and maybe the CLI tests in lighthouse/tests/validator_client.rs.

@michaelsproul michaelsproul added v7.1.0 Post-Electra release backwards-incompat Backwards-incompatible API change labels Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backwards-incompat Backwards-incompatible API change v7.1.0 Post-Electra release waiting-on-author The reviewer has suggested changes and awaits thier implementation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants