-
Notifications
You must be signed in to change notification settings - Fork 927
Allow LH to checkpoint sync into a non-finalized checkpoint #8192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dapplion
wants to merge
13
commits into
sigp:unstable
Choose a base branch
from
dapplion:nonfin-cpsync
base: unstable
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO: Starting from a skipped slot triggered an error:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
We want to allow Lighthouse nodes to start from a non-finalized checkpoint as a way to allow nodes to get un-stuck during long finality. See issue below for more details:
Closes #7089
Proposed Changes
Consider a network where epoch 1000 is finalized, epoch 1001 is justified but we start the node from a state at epoch 2000. The node needs to advertise to its peers and construct attestations setting its finalized checkpoint to epoch 1000 and justified checkpoint to epoch 1001. However, the states of those checkpoints are not available.
I have reviewed all places where that can be a problem, let's go one by one.
Attestation production
EarlyAttesterCache
onadd_head_block
we use the checkpoints in the post state as source of truthState cache
ReqResp Status
Fork-choice internals
is_finalized_checkpoint_or_descendant
needs updating as it assumes the finalized node existEL fork_choice_updated
DB migration
fork_revert
Testing
In progress