Skip to content

Conversation

jimmygchen
Copy link
Member

@jimmygchen jimmygchen commented Oct 13, 2025

Issue Addressed

beacon-chain-tests is now regularly taking 1h+ on CI since Fulu fork was added.

This PR attemtpts to reduce the test time by bringing down the number of blobs generated in tests.

Note: The blobs are pre-generated and doesn't require too much CPU to generate however processing a larger number of them on the beacon chain does take more time.

@jimmygchen jimmygchen requested a review from jxs as a code owner October 13, 2025 05:33
@jimmygchen jimmygchen marked this pull request as draft October 13, 2025 05:41
@jimmygchen jimmygchen marked this pull request as ready for review October 14, 2025 06:35
@jimmygchen jimmygchen added the ready-for-review The code is ready for review label Oct 14, 2025
@mergify
Copy link

mergify bot commented Oct 14, 2025

Some required checks have failed. Could you please take a look @jimmygchen? 🙏

@mergify mergify bot added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-review The code is ready for review labels Oct 14, 2025
@jimmygchen
Copy link
Member Author

jimmygchen commented Oct 15, 2025

Interestingly the broadcast validation test failure here was caused by the block not having a blob, and returning a different error message:
https://github.com/sigp/lighthouse/actions/runs/18466275201/job/52674350559?pr=8194

We could probably use set_min_blob_count to make the test deterministic, or assert for different errors depending on whether blob was included in the block.

i'll go with the former method for now as the tests here are already quite complicated.

@jimmygchen jimmygchen added ready-for-review The code is ready for review and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Oct 15, 2025
@mergify
Copy link

mergify bot commented Oct 15, 2025

Some required checks have failed. Could you please take a look @jimmygchen? 🙏

@mergify mergify bot added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-review The code is ready for review labels Oct 15, 2025
@jimmygchen jimmygchen added ready-for-review The code is ready for review and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Oct 20, 2025
@mergify
Copy link

mergify bot commented Oct 20, 2025

Some required checks have failed. Could you please take a look @jimmygchen? 🙏

@mergify mergify bot added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-review The code is ready for review labels Oct 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

infra-ci test improvement Improve tests waiting-on-author The reviewer has suggested changes and awaits thier implementation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant