Skip to content

Conversation

eserilev
Copy link
Member

@eserilev eserilev commented Oct 14, 2025

Issue Addressed

#6572

Proposed Changes

Remove data column info usage and add a non-reversible migration script.

Also fixes an issue mentioned in this comment regarding data column rpc requests:
#6572 (comment)

Additional Info

The migration script doesn't necessarily need to be non-reversible. Downgrading could technically just be a no-op.

@eserilev eserilev changed the title Deprecate data column info Deprecate DataColumnInfo Oct 14, 2025
@eserilev eserilev added v8.0.0 Q4 2025 Fusaka Mainnet Release das Data Availability Sampling ready-for-review The code is ready for review database fulu Required for the upcoming Fulu hard fork labels Oct 14, 2025
@eserilev eserilev changed the title Deprecate DataColumnInfo Remove DataColumnInfo Oct 14, 2025
@eserilev
Copy link
Member Author

Write a test

Comment on lines +1161 to +1162
debug!("Deneb fork is disabled");
return Err((RpcErrorResponse::InvalidRequest, "Deneb fork is disabled"));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could be Fulu or Deneb that is disabled, but I think it's not wrong to say Fulu is disabled (because Deneb being disabled also implies Fulu being disabled).

Suggested change
debug!("Deneb fork is disabled");
return Err((RpcErrorResponse::InvalidRequest, "Deneb fork is disabled"));
debug!("Fulu fork is disabled");
return Err((RpcErrorResponse::InvalidRequest, "Fulu fork is disabled"));

@jimmygchen jimmygchen added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-review The code is ready for review labels Oct 15, 2025
@michaelsproul michaelsproul added v8.1.0 Post-Fulu release and removed v8.0.0 Q4 2025 Fusaka Mainnet Release labels Oct 16, 2025
@michaelsproul
Copy link
Member

Bumping this to v8.1.0 due to the schema change. We can do the RPC alone in its own PR

@michaelsproul michaelsproul added the backwards-incompat Backwards-incompatible API change label Oct 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backwards-incompat Backwards-incompatible API change das Data Availability Sampling database fulu Required for the upcoming Fulu hard fork v8.1.0 Post-Fulu release waiting-on-author The reviewer has suggested changes and awaits thier implementation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants