Prepare sensitive_url
for crates.io
#8223
Open
+223
−91
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Another good candidate for publishing separately from Lighthouse is
sensitive_url
as it's a general utility crate and not related to Ethereum. This PR prepares it to be spun out into its own crate.Proposed Changes
I've made the
full
field onSensitiveUrl
private and instead provided an explicit getter called.expose_full()
. It's a bit ugly for the diff but I prefer the explicit nature of the getter.I've also added some extra tests and doc strings along with feature gating
Serialize
andDeserialize
implementations behind theserde
feature.Additional Info
I also removed
AsRef<str>
as this was previously used quite awkwardly and instead I've implemented a.redacted()
getter which I think is cleaner.