Skip to content

Conversation

pawanjay176
Copy link
Member

Issue Addressed

N/A

Proposed Changes

We were publishing columns all columns that we didn't already have in the da cache when reconstructing. This is unnecessary outbound bandwidth for the node that is supposed to sample fewer columns.
This PR changes the behaviour to publish only columns that we are supposed to sample in the topics that we are subscribed to.

@pawanjay176 pawanjay176 marked this pull request as ready for review October 22, 2025 23:22
@pawanjay176 pawanjay176 added the ready-for-review The code is ready for review label Oct 22, 2025
@mergify
Copy link

mergify bot commented Oct 23, 2025

Some required checks have failed. Could you please take a look @pawanjay176? 🙏

@mergify mergify bot added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-review The code is ready for review labels Oct 23, 2025
Copy link
Member

@jimmygchen jimmygchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and a safe change to merge!

Just a failing test that needs update here:
https://github.com/sigp/lighthouse/actions/runs/18732633772/job/53432828777?pr=8269

@jimmygchen jimmygchen mentioned this pull request Oct 23, 2025
jimmygchen added a commit that referenced this pull request Oct 23, 2025
Squashed commit of the following:

commit 5d7acdb
Author: Pawan Dhananjay <[email protected]>
Date:   Wed Oct 22 16:19:11 2025 -0700

    Only publish columns that we also sample
@jimmygchen jimmygchen added ready-for-merge This PR is ready to merge. v8.0.0 Q4 2025 Fusaka Mainnet Release and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Oct 23, 2025
@mergify mergify bot added the queued label Oct 23, 2025
mergify bot added a commit that referenced this pull request Oct 23, 2025
mergify bot added a commit that referenced this pull request Oct 23, 2025
@mergify mergify bot merged commit c668cb7 into sigp:unstable Oct 23, 2025
37 checks passed
@mergify mergify bot removed the queued label Oct 23, 2025
mergify bot pushed a commit that referenced this pull request Oct 23, 2025
Open PRs to include for the release
- #7907
- #8247
- #8251
- #8253
- #8254
- #8265
- #8269
- #8266


  


Co-Authored-By: Jimmy Chen <[email protected]>

Co-Authored-By: Jimmy Chen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-merge This PR is ready to merge. v8.0.0 Q4 2025 Fusaka Mainnet Release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants