update simplewebauthn to v13.3.0#284
Merged
Merged
Conversation
briskt
requested review from
ethancanne,
forevermatt,
hobbitronics and
mtompset
and removed request for
a team
mtompset
reviewed
May 26, 2026
mtompset
reviewed
May 26, 2026
mtompset
reviewed
May 26, 2026
mtompset
approved these changes
May 26, 2026
Contributor
Did you mean, "Base64url encode the user ID before passing to |
forevermatt
approved these changes
May 26, 2026
forevermatt
left a comment
forevermatt
left a comment
Contributor
There was a problem hiding this comment.
Thank you for figuring this out 👍
Contributor
Author
Yes, thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IDP-2026 Re-Upgrade SimpleWebAuthn
Changed
startRegistrationto conform to the new API.startAuthentication. This is necessary to maintain compatibility with passkeys saved by earlier versions of sil-org/idp-profile-ui. Even though the user ID is already base64url-encoded by the go-webauthn library in serverless-mfa-api-go changes in simplewebauthn require that we double-encode it. The simplewebauthnstartAuthenticationfunction will immediately decode it, removing the outer layer of encoding, before sending it to the browser. Passkeys saved in our database and in clients (mobile devices, password managers, etc.) have user IDs that are base64url-encoded UUID strings so if we didn't double-encode it,startAuthenticationwould decode it to a plain text UUID string.Feature branch checklist
make formatandmake depsupdate