Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 5.5.2 -- log the app version #179

Merged
merged 1 commit into from
Mar 4, 2025
Merged

Release 5.5.2 -- log the app version #179

merged 1 commit into from
Mar 4, 2025

Conversation

briskt
Copy link
Contributor

@briskt briskt commented Mar 4, 2025 •
edited by ethancanne
Loading

Added

  • Include app version in log messages

PR Checklist

  • Put version number in PR title (e.g. Release x.y.z - Summary of changes)
  • Documentation (README, etc.)
  • Unit tests created or updated
  • Run make composershow

@briskt briskt requested review from a team as code owners March 4, 2025 09:17
@briskt briskt requested review from forevermatt, mtompset, ethancanne and jason-jackson and removed request for a team March 4, 2025 09:17
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Mar 4, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

ethancanne
ethancanne approved these changes Mar 4, 2025
View reviewed changes
Copy link

@ethancanne ethancanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@briskt
Copy link
Contributor Author

briskt commented Mar 4, 2025

Looks good!

Thanks for the review. 😄

@briskt briskt merged commit 1931982 into main Mar 4, 2025
3 checks passed
@briskt briskt deleted the feature/log-version branch March 4, 2025 14:54
@briskt briskt changed the title Release 3.5.2 -- log the app version Release 5.5.2 -- log the app version Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethancanne ethancanne ethancanne approved these changes

@forevermatt forevermatt Awaiting requested review from forevermatt forevermatt is a code owner automatically assigned from silinternational/php-devs

@mtompset mtompset Awaiting requested review from mtompset mtompset is a code owner automatically assigned from silinternational/php-devs

@jason-jackson jason-jackson Awaiting requested review from jason-jackson jason-jackson is a code owner automatically assigned from silinternational/php-devs

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@briskt @ethancanne