TT-6985 Refactor ProjectsScreen to simplify admin workflow modification logic #164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on logic This update modifies the logic for determining if a user can modify the workflow in the ProjectsScreen component. The check for personal team status has been removed, streamlining the conditions under which workflow modifications are allowed. This change enhances code clarity and maintains the intended functionality. Key Changes: - Removed the isPersonal check from the canModifyWorkflow logic - Updated dependencies in the useMemo hook accordingly
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the canModifyWorkflow logic in the ProjectsScreen component by removing the isPersonal check and its associated dependency. This changes the behavior to now allow workflow modification for personal teams/projects, whereas previously personal teams were explicitly excluded from workflow modification capabilities.
Key Changes:
- Removed the
isPersonalcondition from thecanModifyWorkflowcheck (line 197) - Updated the
useMemodependency array to removeisPersonal(line 202)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update modifies the logic for determining if a user can modify the workflow in the ProjectsScreen component. The check for personal team status has been removed, streamlining the conditions under which workflow modifications are allowed. This change enhances code clarity and maintains the intended functionality.
Key Changes: