Skip to content

Fix scope path to end with slash #927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chrisvire merged 2 commits into from
Jan 16, 2026
Merged

Fix scope path to end with slash #927

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dc18a4f
Fix scope path to end with slash
chrisvire Jan 16, 2026
8d5878c
Make scope and start_url consistent
chrisvire Jan 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions convert/convertManifest.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,16 @@ export function convertManifest(dataDir: string, verbose: number) {
contents = lines
.map((line) => {
if (line.includes('start_url')) {
const path = process.env.BUILD_BASE_PATH ? process.env.BUILD_BASE_PATH : '.';
line = ` "start_url" : "${path}/",`;
const urlPath = process.env.BUILD_BASE_PATH ? process.env.BUILD_BASE_PATH : '.';
line = ` "start_url" : "${urlPath}/",`;
}
Comment thread
chrisvire marked this conversation as resolved.
if (line.includes('scope')) {
const path = process.env.BUILD_BASE_PATH ? process.env.BUILD_BASE_PATH : '/';
line = ` "scope" : "${path}",`;
const scopePath = process.env.BUILD_BASE_PATH
? process.env.BUILD_BASE_PATH.endsWith('/')
? process.env.BUILD_BASE_PATH
: process.env.BUILD_BASE_PATH + '/'
: '/';
line = ` "scope" : "${scopePath}",`;
}
Comment thread
coderabbitai[bot] marked this conversation as resolved.
if (line.includes('"src":') && line.includes('./icons')) {
const srcMatch = line.match(/"src"\s*:\s*"\.\/([^"]+)"/);
Expand Down
10 changes: 9 additions & 1 deletion svelte.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,14 @@ const packageJson = JSON.parse(readFileSync('package.json', 'utf-8'));
const templateVersion = packageJson.version;
const buildTimestamp = Date.now();

// Scope should end with a slash if defined
// BUILD_BASE_PATH should not have a trailing slash, but just make sure
const serviceWorkerScope = process.env.BUILD_BASE_PATH
? process.env.BUILD_BASE_PATH.endsWith('/')
? process.env.BUILD_BASE_PATH
: process.env.BUILD_BASE_PATH + '/'
: '/';

/** @type {import('@sveltejs/kit').Config} */
const config = {
// Consult https://github.com/sveltejs/svelte-preprocess
Expand Down Expand Up @@ -34,7 +42,7 @@ const config = {
},
serviceWorker: {
options: {
scope: process.env.BUILD_BASE_PATH
scope: serviceWorkerScope
}
},
version: {
Expand Down