-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use chg in LfMerge, only in local dev LF for now #1842
Conversation
Unit Test Results362 tests 362 ✅ 13s ⏱️ Results for commit 223c2fa. ♻️ This comment has been updated with latest results. |
looks like our PNPM install is failing in LF too, would you mind looking into that? I'm fine if you merge this PR without fixing it as they're totally unrelated |
Huh. So there's some kind of problem with NPM's signing infrastructure and it's unrelated to the specific PNPM 9.15.5 release (LF is still on 9.11.0). Weird; hopefully they sort it out soon because that's going to affect millions of projects. I'll try rerunning the failed GHA builds once in case it's already been sorted out, then if it's still failing across the board I'll just merge this. |
Corepack bug present in the corepack versions distributed with NPM (corepack 0.30.0). Running |
That solved the PNPM install issue, only to run into a different issue: "Package |
Fixes #1841
Description
We'll start using
chg
for LfMerge in local LF development; once we know that it works, we'll add the relevant environment variable to the k8s deployment so that staging and then prod also start getting the same Send/Receive speedups.Checklist
Testing