Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pilx] scanning motor ranges are not used when displaying the image #2383

Closed
kif opened this issue Jan 20, 2025 · 2 comments · Fixed by #2394
Closed

[pilx] scanning motor ranges are not used when displaying the image #2383

kif opened this issue Jan 20, 2025 · 2 comments · Fixed by #2394
Assignees
@EdgarGF93
Labels
bug Serious issue, to be addressed in priority !

Comments

@kif
Copy link
Member

kif commented Jan 20, 2025

diffmap generates the 2 arrays with the scan motor name containing their position but this information is not used for the display.

reported by ID27.
@kif kif added the bug Serious issue, to be addressed in priority ! label Jan 20, 2025
@kif
Copy link
Member Author

kif commented Jan 22, 2025

Update as well how units are handled in diffmap.py : there are still a lot of unit.split("_")[0]

@kif kif mentioned this issue Jan 23, 2025
Merged
@kif
Copy link
Member Author

kif commented Jan 27, 2025 •
edited
Loading

Silx is now able to recognize the axis names and motor position and display them properly:
Image
In pilx, it is not yet the case ...
Image

The screenshots were taken with the branch kif/diffmap, PR #2394

@kif kif mentioned this issue Jan 27, 2025
Merged
@kif kif closed this as completed in 4aabe99 Jan 30, 2025
@kif kif closed this as completed in #2394 Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EdgarGF93 EdgarGF93

Labels
bug Serious issue, to be addressed in priority !
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Diffmap enhancements kif/pyFAI
2 participants
@kif @EdgarGF93