-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Diffmap enhancements #2394
Diffmap enhancements #2394
Conversation
Continuing with the conversation from the other PR, I am thinking that the |
To me it is a nonsense to bin pixel-detector data ... so for Dectris I consider it makes little sense. |
if isinstance(axes, Iterable): | ||
radial_path = axes[0] | ||
if size is not None: | ||
for idx in [0, -1, 1, -2]: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we can check for the size, what about going through all axes
elements instead of these specific indices ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I intent to make the default view (in the Nexus sense) on the map
array, not on the intensity
array. This is to try to ensure the different axes have the proper shape while keeping the compatibility with former files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's check how pilx reacts with files produced with former version of pyFAI ...
for more information, see https://pre-commit.ci
close #2396 |
Undo multithreading implementation, no gain
TODO: check pilx for the opening of diffmap files from v 2024.X |
pyfai-diffmap-view from the current branch can handle diffmap files generated with config files v3, v4 and v5.
pyFAI 2024.05 uses a configuration file version 3 |
Yes, but this branch provides the motor position handling in addition. |
But 2024.x version of pyFAI cannot open the new diffmap files
|
This is an expected bug ... It would be extremely complex to make
code "forward-compatible" without a lot of planning and design ...
|
Start using WorkerConfig
Update the way polarization works
close #2396
close #2390
close #2383
close #2382