[IO] Improve image stack handling#1122
Merged
Merged
Conversation
Member
Author
Indeed. Too many possibilities offered to users. For instance, Canadian Light Source prefers to be able to select multiple datasets per scan to have PyMca perform the addition of separate channels of a multielement detector. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code as it was written was only dealing with a single dataset of images.
This PR makes sure if multiple scans and datasets are selected, they are properly summed.
It falls back to the case the data were not fitting into memory that was lost when avoiding a loop.