Skip to content

[IO] Improve image stack handling#1122

Merged
vasole merged 1 commit into
masterfrom
vasole-patch-2
May 13, 2025
Merged

[IO] Improve image stack handling#1122
vasole merged 1 commit into
masterfrom
vasole-patch-2

Conversation

@vasole
Copy link
Copy Markdown
Member

@vasole vasole commented May 13, 2025

The code as it was written was only dealing with a single dataset of images.

This PR makes sure if multiple scans and datasets are selected, they are properly summed.

It falls back to the case the data were not fitting into memory that was lost when avoiding a loop.

@vasole vasole requested a review from woutdenolf May 13, 2025 16:20
Copy link
Copy Markdown
Collaborator

@woutdenolf woutdenolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oef tricky stuff

@vasole
Copy link
Copy Markdown
Member Author

vasole commented May 13, 2025

Oef tricky stuff

Indeed. Too many possibilities offered to users.

For instance, Canadian Light Source prefers to be able to select multiple datasets per scan to have PyMca perform the addition of separate channels of a multielement detector.

@vasole vasole merged commit 3a3529d into master May 13, 2025
6 checks passed
@vasole vasole deleted the vasole-patch-2 branch May 13, 2025 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants