-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve ruler #4005
Improve ruler #4005
Conversation
short answer: fine with me 👍 . Try to get something as much as possible 'readable' by default for colormap like 'grayscale' and that's it. |
Regarding dashed line support, as a general rule, I prefer to stick to matplotlib naming/default style whenever possible and to have the OpenGL backend behave as close as possible to it. So I'd prefer to add support for (offset, (dashes)) as in matplotlib |
BTW, did you try with dashed dot: |
I just try, that's not very nice |
Only supporting the subset |
ok, then I'll add this |
# Conflicts: # src/silx/gui/plot/PlotToolButtons.py
a1ea173
to
4ca9025
Compare
Everything was rebased using the new features from the main branch. Still some commit could be cherry picked alone to the main branch, but it's mostly typing. This can be reviewed. |
Fine with the source code, works well on my side. I don't have any strong opinion regarding splitting out the |
This PR improve the ruler from the plot with a default fixed dashed style
No need changelog, it's a new feature