silx view: Fix display of RGB images stored in NXdata #4433
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loichuder
commented
Sep 30, 2025
| self.getAggregationModeAction().getAggregationMode() | ||
| ) | ||
| elif image.ndim == 3: | ||
| imageItem = items.ImageRgba() |
There was a problem hiding this comment.
This is a quick fix. I think the best thing would be to handle the aggregation inside the addImage method of self._plot to avoid duplicating the behaviour of it.
We will have to discuss it together.
There was a problem hiding this comment.
Not sure, the toolbar would also need to be updated accordingly.
There was a problem hiding this comment.
Indeed, see #4434
Let's leave it like that for now and think later of a refactoring with a bigger scope.
loichuder
commented
Sep 30, 2025
| self.__views = {} | ||
| self.__currentView = None | ||
|
|
||
| def getCurrentView(self): |
There was a problem hiding this comment.
For the newly added tests
t20100
approved these changes
Oct 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<Module or Topic>: <Action> <Summary>(see contributing guidelines)Fix #4432