Skip to content

Conversation

kif
Copy link
Member

@kif kif commented Oct 4, 2025

Fix the issue discussed about CI/CD not able to run on edna-site.

Copy link
Member

@t20100 t20100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good if it no longer writes in the installed folder!

:param verbosity: Requested level of verbosity
:param args: List of extra arguments to pass to `pytest`
"""
workdir = tempfile.mkdtemp(prefix="silx-")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doc says:

The user of mkdtemp() is responsible for deleting the temporary directory and its contents when done with it.

IMO best to use tempfile.TemporaryDirectory context manager to take care of it

@vallsv
Copy link
Contributor

vallsv commented Oct 8, 2025

Could we link the issue related to this change, because it don't really see why the tests would not be read only.

@t20100
Copy link
Member

t20100 commented Oct 8, 2025

Could we link the issue related to this change, because it don't really see why the tests would not be read only.

related to #4225

It's pytest writing some cache folder where the Python package is installed.... It really shouldn't.

@vallsv
Copy link
Contributor

vallsv commented Oct 8, 2025

It's pytest writing some cache folder where the Python package is installed.... It really shouldn't.

Thanks. Yes, i think it would be good to feedback the problem upstream if it's not already the case. So what we could add a related comment in code of this PR, so what it could be drop in the future (in case the pytest people think that's a problem on there side).

My 2 cents.

@t20100 t20100 merged commit 6de2beb into silx-kit:main Oct 17, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants