Incorporate Zepheira commits #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y with require.js
… Note data-structure broke out to set, sorted-array, and event-index, and bubble broke out from graphics to help avoid dependency cycles. See main.js for example usage.
…; for publishing, it should be changed to the canonical SimileAjax URL for this version of itself
…don't bother loading jquery in simileajax anymore either
…d non-AMD-aware projects; removing jsmin-task material
…s compatibility, can load a requirejs bundle or a non-requirejs bundle, or use requirejs for non-bundling; the preference is to use requirejs to load main.js instead of following old patterns, but the old way should work. also removed jquery and i18n plugin.
…fault to mimic old behavior; move project specific settings into a hash, correct onerror / onload property setting
…g it, though this is an esoteric case; either use RequireJS correctly without going through simile-ajax-api or skip RequireJS when using simile-ajax-api; this may be amended before final release to avoid weirdness
…ajax-api.js is a legacy mode and shouldn't bother trying to figure out RequireJS presence; adding CSS optimizing (though only one file right now), adding to build and deploy
… css (barely matters for this project
…te require path; eliminating simile-ajax-api since it just forwards to a bundle, building it as a bundle; renaming require bundle output to simile-ajax-bundle.js
…all SimileAjax.load as early as possible without missing document.body
…during development
…an cause timing problems; do not autoload simileajax either, SimileAjax.load must be called externally (it is, after all, a library). removing domReady, unnecessary now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Zepheira contributed a number of commits to the simile ajax codebase. Unfortunately their branch was generated separately from the original google code subversion repository, so github doesn't recognize the two repositories as related and won't simply merge the commits. Instead, cherry-picking is necessary.