Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring MI into python #73

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

asistradition
Copy link

I'm breaking this down into smaller, more manageable chunks; this is the refactor of the mutual information calculations into pure python, using KVS to multiprocess. There's a new wrapper for the KVS client that gives a bit more functionality, and the MI module is a drop-in replacement for the mi_R module.

I've also included a few minor changes to the workflow that should substantially help the memory usage.

@codecov-io
Copy link

codecov-io commented Nov 19, 2018

Codecov Report

Merging #73 into master will increase coverage by 2.35%.
The diff coverage is 91.37%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #73      +/-   ##
=========================================
+ Coverage   72.25%   74.6%   +2.35%     
=========================================
  Files          20      22       +2     
  Lines        1600    1768     +168     
=========================================
+ Hits         1156    1319     +163     
- Misses        444     449       +5
Impacted Files Coverage Δ
inferelator_ng/bbsr_tfa_workflow.py 0% <0%> (ø) ⬆️
inferelator_ng/workflow.py 75% <0%> (ø) ⬆️
inferelator_ng/tests/test_mi.py 100% <100%> (ø)
inferelator_ng/tests/test_workflow_stub.py 65.38% <100%> (ø) ⬆️
inferelator_ng/tests/test_kvs.py 100% <100%> (ø)
inferelator_ng/utils.py 59.45% <78.57%> (-11.13%) ⬇️
inferelator_ng/mi.py 95.74% <95.74%> (ø)
inferelator_ng/kvs_controller.py 96.29% <96.29%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65eb90e...8004262. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants