-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ttwww-336: Upgrade django and python packages that Prevalance map uses #36
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prisma Cloud has found errors in this PR ⬇️
@@ -1,7 +1,7 @@ | |||
astroid==1.6.5 | |||
backports.functools-lru-cache==1.5 | |||
configparser==3.5.0 | |||
Django==1.11.17 | |||
Django==3.2 |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is absolutely not 'off topic'
Why are we only moving to Django 3.2.0? That's quite old at this point, and as Prisma is pointing out, has several security holes. Please look at using at least 3.2.25 to use the latest 3.2.x series. Thanks!
@roarmeow I use pyenv uninstall to get rid of all the versions, and pyenv install 3.10.13, then run command pyenv local 3.10.13 under project directory, and then go ahead installing the packages. Worked fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good; it took me so long it might be a little out of date, but everything works as expected. Thanks for your patience!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make certain to use the latest release in the package series' you are using, to ensure that we are not leaving security holes open needlessly. Thanks!
Jira ticket: TTWWW-336
To test:
pyenv
or other tools to choose python3 version 3.10.13 for the project.(could run commandpyenv local 3.10.13
under project directory)python3 -m venv prevalence
under project root directory.pip install -r requirements.txt
under project root directory.python manage.py runserver
under directoryspectrum