Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ttwww-336: Upgrade django and python packages that Prevalance map uses #36

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

yjfnyc
Copy link

@yjfnyc yjfnyc commented Sep 10, 2024

Jira ticket: TTWWW-336

To test:

  • Install pyenv or other tools to choose python3 version 3.10.13 for the project.(could run command pyenv local 3.10.13 under project directory)
  • Check out this branch
  • run command python3 -m venv prevalence under project root directory.
  • run command pip install -r requirements.txt under project root directory.
  • run command python manage.py runserver under directory spectrum
  • Access backend admin and confirm all well.
  • Access frontend 127.0.0.1:8000, and confirm all works well.
  • Access backend to do the bulk import, and confirm data can be imported successfully.(data can be downloaded from the prevalence map live site as a csv file)

Copy link

@prisma-cloud-devsecops prisma-cloud-devsecops bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prisma Cloud has found errors in this PR ⬇️

@@ -1,7 +1,7 @@
astroid==1.6.5
backports.functools-lru-cache==1.5
configparser==3.5.0
Django==1.11.17
Django==3.2

This comment was marked as off-topic.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is absolutely not 'off topic'

Why are we only moving to Django 3.2.0? That's quite old at this point, and as Prisma is pointing out, has several security holes. Please look at using at least 3.2.25 to use the latest 3.2.x series. Thanks!

@yjfnyc yjfnyc changed the title ttwww-336: initial work for upgrade django ttwww-336: Upgrade django and python packages that Prevalance map uses Sep 10, 2024
@yjfnyc yjfnyc marked this pull request as ready for review September 12, 2024 13:45
@yjfnyc yjfnyc requested a review from roarmeow September 12, 2024 13:46
@yjfnyc
Copy link
Author

yjfnyc commented Oct 1, 2024

@roarmeow I use pyenv uninstall to get rid of all the versions, and pyenv install 3.10.13, then run command pyenv local 3.10.13 under project directory, and then go ahead installing the packages. Worked fine.

Copy link

@roarmeow roarmeow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good; it took me so long it might be a little out of date, but everything works as expected. Thanks for your patience! :shipit:

Copy link

@mdmallardi mdmallardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make certain to use the latest release in the package series' you are using, to ensure that we are not leaving security holes open needlessly. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants