Skip to content

fixes #289 networkmanager returns null keys for some connections.#290

Open
dforste wants to merge 2 commits into
simp:masterfrom
dforste:patch-2
Open

fixes #289 networkmanager returns null keys for some connections.#290
dforste wants to merge 2 commits into
simp:masterfrom
dforste:patch-2

Conversation

@dforste

@dforste dforste commented Aug 30, 2023

Copy link
Copy Markdown
Contributor

Refactor networkmanager connections so connections without a device are addressable. Prevents null keys from being inserted.

Refactor networkmanager connections so connections without a device are addressable. Prevents null keys from being inserted.
@silug

silug commented Aug 30, 2023

Copy link
Copy Markdown
Contributor

@dforste Do you have nmcli output that triggers this bug? I'd like to add a test.

@silug silug self-assigned this Aug 30, 2023
@dforste

dforste commented Aug 31, 2023

Copy link
Copy Markdown
Contributor Author

Example output:

# nmcli connection
NAME           UUID                                  TYPE      DEVICE
System ens160  ea74cf24-c2a2-ecee-3747-a2d76d46f93b  ethernet  ens160
lo             04577901-581b-4cac-bb04-f015fe36274d  loopback  lo
ens160         5780e094-7abe-419a-9c3e-de716150898d  ethernet  --

# nmcli -t connection
System ens160:ea74cf24-c2a2-ecee-3747-a2d76d46f93b:802-3-ethernet:ens160
lo:04577901-581b-4cac-bb04-f015fe36274d:loopback:lo
ens160:5780e094-7abe-419a-9c3e-de716150898d:802-3-ethernet:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

3 participants