Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mistral-prompter #19

Merged
merged 29 commits into from
Oct 18, 2024
Merged

Mistral-prompter #19

merged 29 commits into from
Oct 18, 2024

Conversation

Linh-nk
Copy link
Collaborator

@Linh-nk Linh-nk commented Sep 23, 2024

Mistral-prompter pipelines. Could you please take a look at this new PR? Thank you!

Note: There are 3 failed lint tests that I couldn't resolve yet (import errors).

@Linh-nk Linh-nk requested a review from sarahmish September 24, 2024 15:37
Copy link
Contributor

@sarahmish sarahmish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Linh-nk for the great work!

Couple of changes that need to be made:

  • revert all changes to the file transformation.py file, keep this file unchanged from master
  • delete readme_test folder from the PR, this is a test output that shouldn't be committed
  • move tutorials/prompter.ipynb to tutorials/pipelines/prompter-pipeline.ipynb
  • proposing changes to some of the primitive names, the clearer they are, the better:
    • ano_within_windows -> find_anomalies_in_windows
    • merge_anomaly_seq -> merge_anomalous_sequences

sigllm/pipelines/prompter/mistral_prompter.json Outdated Show resolved Hide resolved
sigllm/primitives/prompting/anomalies.py Outdated Show resolved Hide resolved
sigllm/primitives/prompting/huggingface.py Outdated Show resolved Hide resolved
@Linh-nk Linh-nk requested a review from sarahmish October 3, 2024 15:05
Copy link
Contributor

@sarahmish sarahmish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent PR @Linh-nk! After updating the notebook with the correct interval, please go ahead and merge it!

@Linh-nk Linh-nk merged commit 3ecdc97 into master Oct 18, 2024
26 checks passed
@Linh-nk Linh-nk deleted the prompter branch October 18, 2024 13:58
@sarahmish sarahmish added the enhancement New feature or request label Oct 24, 2024
@sarahmish sarahmish added this to the 0.0.2 milestone Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants