-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mistral-prompter #19
Mistral-prompter #19
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Linh-nk for the great work!
Couple of changes that need to be made:
- revert all changes to the file
transformation.py
file, keep this file unchanged from master - delete
readme_test
folder from the PR, this is a test output that shouldn't be committed - move
tutorials/prompter.ipynb
totutorials/pipelines/prompter-pipeline.ipynb
- proposing changes to some of the primitive names, the clearer they are, the better:
ano_within_windows
->find_anomalies_in_windows
merge_anomaly_seq
->merge_anomalous_sequences
sigllm/primitives/jsons/sigllm.primitives.prompting.anomalies.timestamp2interval.json
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent PR @Linh-nk! After updating the notebook with the correct interval, please go ahead and merge it!
Mistral-prompter pipelines. Could you please take a look at this new PR? Thank you!
Note: There are 3 failed lint tests that I couldn't resolve yet (import errors).