Https/GitHub.com/alan840706/micropython #472

alan840706 · 2022-08-25T09:54:06Z

No description provided.

vowstar · 2022-08-25T15:26:28Z

components/micropython/a

@@ -0,0 +1 @@
+


This empty file was added by mistake and needs to be cleaned up

vowstar · 2022-08-25T15:27:59Z

components/micropython/port/src/omv/img/bmp.c

@@ -257,6 +257,7 @@ void bmp_write_subimg(image_t *img, const char *path, rectangle_t *r)
        for (int i = 0; i < 256; i++) {
            write_long_raise(file, ((i) << 16) | ((i) << 8) | i);
        }
+        printf("OK1!\n");


Need to clean up unnecessary code

vowstar · 2022-08-25T15:28:37Z

components/micropython/port/src/omv/img/bmp.c

@@ -270,6 +271,7 @@ void bmp_write_subimg(image_t *img, const char *path, rectangle_t *r)
            }
        }
    } else {
+        printf("OK2!\n");


Need to clean up unnecessary code

vowstar · 2022-08-25T15:29:43Z

components/micropython/port/src/omv/img/draw.c

@@ -31,7 +31,7 @@ int imlib_get_pixel(image_t *img, int x, int y)

 // Set pixel (handles boundary check and image type check).
 void imlib_set_pixel(image_t *img, int x, int y, int p)
-{
+{	


Unnecessary trailing space

vowstar · 2022-08-25T15:29:58Z

components/micropython/port/src/omv/py/py_image.c

@@ -652,18 +652,22 @@ STATIC mp_obj_t py_image_set_pixel(size_t n_args, const mp_obj_t *args, mp_map_t
    switch (arg_img->bpp) {
        case IMAGE_BPP_BINARY: {
            IMAGE_PUT_BINARY_PIXEL(arg_img, arg_x, arg_y, arg_c);
+            //printf("0");


Need to clean up unnecessary code

vowstar · 2022-08-25T15:30:05Z

components/micropython/port/src/omv/py/py_image.c

            return args[0];
        }
        case IMAGE_BPP_GRAYSCALE: {
            IMAGE_PUT_GRAYSCALE_PIXEL(arg_img, arg_x, arg_y, arg_c);
+            //printf("1");


Need to clean up unnecessary code

vowstar · 2022-08-25T15:30:16Z

components/micropython/port/src/omv/py/py_image.c

            return args[0];
        }
        case IMAGE_BPP_BAYER: {
            IMAGE_PUT_GRAYSCALE_PIXEL(arg_img, arg_x, arg_y, arg_c); // Correct!
+            //printf("3");


Need to clean up unnecessary code

vowstar · 2022-08-25T15:30:35Z

components/micropython/port/src/standard_lib/machine/machine_spi.c


    // only MSB transfer is implemented
-
+    	


Unnecessary trailing space

vowstar · 2022-08-25T15:30:43Z

components/micropython/port/src/standard_lib/machine/machine_spi.c

@@ -142,10 +142,10 @@ void mp_soft_spi_transfer(void *self_in, size_t len, const uint8_t *src, uint8_t
    machine_hw_spi_obj_t *self = (machine_hw_spi_obj_t*)self_in;
    uint32_t delay_half = self->delay_half;

-    // printk("%s %d %d %d\r\n", __func__, self->pin_sck, self->pin_d[0], self->pin_d[1]);
+     


Unnecessary trailing space

vowstar · 2022-08-25T15:30:56Z

components/micropython/port/src/standard_lib/machine/machine_spi.c

@@ -523,7 +523,7 @@ STATIC void mp_machine_spi_transfer(mp_obj_t self, size_t len, const void *src,
    spi_p->transfer(s, len, src, dest, cs);
 }

-STATIC mp_obj_t mp_machine_spi_read(size_t n_args, const mp_obj_t *pos_args, mp_map_t *kw_args) {
+STATIC mp_obj_t mp_machine_spi_read(size_t n_args, const mp_obj_t *pos_args, mp_map_t *kw_args) {	


Unnecessary trailing space

vowstar · 2022-08-25T15:34:44Z

components/kendryte_sdk/src/sipeed_spi.c

-        fifo_len = spi_handle->rxflr;
+
+        //fifo_len = spi_handle->rxflr;
+        fifo_len = rx_len;


Please explain the specific reason for the modification here

alan840706 added 30 commits February 4, 2021 22:07

Update project.py

69397de

Update config_defaults_kmodel_v4_support.mk

4e7c673

Update config_defaults_kmodel_v4_support.mk

8a12976

Update config_defaults_kmodel_v4_support.mk

27d3c31

Update config_defaults.mk

b5e9665

Update config_defaults_kmodel_v4_support.mk

fc264ee

Update config_defaults_kmodel_v4_support.mk

f45f7c0

Update config_defaults_kmodel_v4_support.mk

f21b664

Update config_defaults_kmodel_v4_support.mk

42fb7b0

Update config_defaults_kmodel_v4_support.mk

c858fc2

Update config_defaults_kmodel_v4_support.mk

afaf429

Update config_defaults_kmodel_v4_support.mk

f9cb005

Update project.py

e625b7d

Update machine_spi.c

c745f40

Update machine_spi.c

c0497a4

Update machine_spi.c

75037f6

Update machine_spi.c

f5cbf26

Update machine_spi.c

ca477cb

Update machine_spi.c

aecd4d8

Update machine_spi.c

8029e17

Update machine_spi.c

4baa889

Update machine_spi.c

e5d1a48

Update machine_spi.c

016bd6d

Update sipeed_spi.c

ad23e99

Update sipeed_spi.c

9d774bd

Update sipeed_spi.c

a81250c

Update sipeed_spi.c

5019894

Update sipeed_spi.c

499981e

Update sipeed_spi.c

251ab2b

Update sipeed_spi.c

b1483f1

alan840706 added 24 commits August 21, 2021 00:47

Update config_defaults_kmodel_v4_support.mk

dd7e169

Update config_defaults_kmodel_v4_support.mk

6617fb9

Update config_defaults_kmodel_v4_support.mk

b8b08cf

Update config_defaults_kmodel_v4_support.mk

1e6abde

Update config_defaults_kmodel_v4_support.mk

ba7ada0

Update imlib.c

0bac2ce

Update imlib.c

82c9340

Update bmp.c

41018db

Update bmp.c

c851ae4

Update bmp.c

9489619

Update bmp.c

f4ddaf8

Update bmp.c

e3cd886

Update bmp.c

95bb264

Update draw.c

8d10493

Update draw.c

8b2d462

Update draw.c

44d4620

Update draw.c

ba4f611

Update draw.c

224b5ba

Update draw.c

d01e4b6

Update py_image.c

8e8c001

Update py_image.c

44b7643

Update py_image.c

f57b332

Update py_image.c

3c7e275

Create a

783874c

vowstar requested review from Neutree and junhuanchen and removed request for Neutree August 25, 2022 15:23

vowstar reviewed Aug 25, 2022

View reviewed changes

components/micropython/a

@@ -0,0 +1 @@

Copy link

Collaborator

vowstar Aug 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This empty file was added by mistake and needs to be cleaned up

vowstar requested changes Aug 25, 2022

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Https/GitHub.com/alan840706/micropython #472

Https/GitHub.com/alan840706/micropython #472

alan840706 commented Aug 25, 2022

vowstar Aug 25, 2022

vowstar Aug 25, 2022

vowstar Aug 25, 2022

vowstar Aug 25, 2022

vowstar Aug 25, 2022

vowstar Aug 25, 2022

vowstar Aug 25, 2022

vowstar Aug 25, 2022

vowstar Aug 25, 2022

vowstar Aug 25, 2022

vowstar Aug 25, 2022

Https/GitHub.com/alan840706/micropython #472

Are you sure you want to change the base?

Https/GitHub.com/alan840706/micropython #472

Conversation

alan840706 commented Aug 25, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment