Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sha256 performance numbers are too low. 1GiB/s throughput and ~100ns latency on 64b is achievable with just a bump in the package version, at least on my box :)
The benchmark uses 64b as its per-iteration chunk size, and this underestimates throughput (559MiB/s). At larger chunk sizes 1-1.5 GiB/s is achievable.
I ran this on
m6i.12xlarge
running Ubuntu 20.04, but I generally find that 1GiB/s is the most accurate 'round number' for how fast sha256 is across our worker fleert.