[BUG] Fix issue with EncodeNormalizer(method='standard', center=False) for scale value - #1902
Conversation
| assert torch.isclose(target.mean(), samples.mean(), atol=0.1, rtol=0.5) | ||
| assert torch.isclose(target.std(), samples.std(), atol=0.1, rtol=0.5) | ||
| if transformation == "log1p" and not center: | ||
| assert torch.isclose(target.std(), samples.std(), atol=0.1, rtol=0.8) |
There was a problem hiding this comment.
The variance distorts when the data is not centered, as the log1p transformation is log(1+x)
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1902 +/- ##
=======================================
Coverage ? 86.25%
=======================================
Files ? 96
Lines ? 7772
Branches ? 0
=======================================
Hits ? 6704
Misses ? 1068
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Linked to this issue, the method of |
|
FYI, if you have time to look at the |
sure will look into this🤞 |
Fixes #1901
This PR fixes the issue with
which was returning
scale_asmeanofxinstead itsstdTemporarily backported lazywhere implementation from
scipy._lib._util.to avoid import errors in thestatsmodelswith the latest scipy version.