-
Notifications
You must be signed in to change notification settings - Fork 885
[ENH] Add v2 interface support for N-BEATS model #2322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
harshsomankar123-tech
wants to merge
2
commits into
sktime:main
Choose a base branch
from
harshsomankar123-tech:add-nbeats-v2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+528
−0
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| FROM public.ecr.aws/d3j8x8q7/olympus-base-python:latest | ||
|
|
||
| WORKDIR /app | ||
|
|
||
| COPY . . | ||
|
|
||
| RUN pip install --no-cache-dir .[dev,all_extras] | ||
|
|
||
| CMD ["/bin/bash"] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,79 @@ | ||
| """NBeats package container.""" | ||
|
|
||
| from pytorch_forecasting.base._base_pkg import Base_pkg | ||
|
|
||
|
|
||
| class NBeats_pkg_v2(Base_pkg): | ||
| """NBeats package container.""" | ||
|
|
||
| _tags = { | ||
| "info:name": "NBeats", | ||
| "authors": ["jdb78"], | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. please add your name as well. |
||
| "capability:exogenous": False, | ||
| "capability:multivariate": False, | ||
| "capability:pred_int": True, | ||
| "capability:flexible_history_length": False, | ||
| } | ||
|
|
||
| @classmethod | ||
| def get_cls(cls): | ||
| """Get model class.""" | ||
| from pytorch_forecasting.models.nbeats._nbeats_v2 import NBeats | ||
|
|
||
| return NBeats | ||
|
|
||
| @classmethod | ||
| def get_datamodule_cls(cls): | ||
| """Get the underlying DataModule class.""" | ||
| from pytorch_forecasting.data.data_module import ( | ||
| EncoderDecoderTimeSeriesDataModule, | ||
| ) | ||
|
|
||
| return EncoderDecoderTimeSeriesDataModule | ||
|
|
||
| @classmethod | ||
| def get_test_train_params(cls): | ||
| """Return testing parameter settings for the trainer. | ||
|
|
||
| Returns | ||
| ------- | ||
| params : dict or list of dict, default = {} | ||
| Parameters to create testing instances of the class | ||
| Each dict are parameters to construct an "interesting" test instance, i.e., | ||
| `MyClass(**params)` or `MyClass(**params[i])` creates a valid test instance. | ||
| `create_test_instance` uses the first (or only) dictionary in `params` | ||
| """ | ||
| from pytorch_forecasting.metrics import QuantileLoss | ||
|
|
||
| params = [ | ||
| {}, | ||
| dict( | ||
| stack_types=["generic"], | ||
| num_blocks=[1], | ||
| num_block_layers=[4], | ||
| widths=[16], | ||
| backcast_loss_ratio=1.0, | ||
| ), | ||
| dict( | ||
| stack_types=["trend", "seasonality"], | ||
| num_blocks=[2, 2], | ||
| widths=[16, 32], | ||
| backcast_loss_ratio=0.5, | ||
| ), | ||
| dict( | ||
| loss=QuantileLoss(quantiles=[0.1, 0.5, 0.9]), | ||
| stack_types=["generic"], | ||
| num_blocks=[1], | ||
| widths=[16], | ||
| ), | ||
| ] | ||
|
|
||
| default_dm_cfg = {"max_encoder_length": 8, "max_prediction_length": 2} | ||
|
|
||
| for param in params: | ||
| current_dm_cfg = param.get("datamodule_cfg", {}) | ||
| default_dm_cfg.update(current_dm_cfg) | ||
|
|
||
| param["datamodule_cfg"] = default_dm_cfg | ||
|
|
||
| return params | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we have this docker file?