[ENH] Add multiloss support for v2 by adding one more dimension to x and y - #2356
Draft
phoeenniixx wants to merge 2 commits into
Draft
[ENH] Add multiloss support for v2 by adding one more dimension to x and y#2356phoeenniixx wants to merge 2 commits into
x and y#2356phoeenniixx wants to merge 2 commits into
Conversation
phoeenniixx
added
enhancement
Member
Author
|
tests will fail as i still need to add support to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for MultiLoss to ptf v2
Fixes #2308
Changes
weightsto thecollate_fnand__getitem__(of private dataset class of datamodule) return forMultiLoss. The return would be(x, (y, weight))in place of(x,y).Done to:
EncoderDecoderTimeSeriesDataModuleTslibDataModuleBaseModel.