[ENH] refactor _clone to a plugin structure
#381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fkiraly
added
implementing framework
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
for more information, see https://pre-commit.ci
… clone_plugins
for more information, see https://pre-commit.ci
… clone_plugins
for more information, see https://pre-commit.ci
… clone_plugins
This reverts commit 91a876d.
This reverts commit a8dd391.
This reverts commit 35f686a.
This reverts commit 8efb6ed.
| """ | ||
| __all__ = ["_clone", "_check_clone"] | ||
|
|
||
| from skbase.base._clone_plugins import DEFAULT_CLONE_PLUGINS |
Check notice
Code scanning / CodeQL
Cyclic import Note
for more information, see https://pre-commit.ci
… clone_plugins
for more information, see https://pre-commit.ci
… clone_plugins
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the current
_clonelogic, which had a lot of if/else case distinctions (as in thesklearnnative code) to a list of plugins that can be extended.Above the refactor, it also adds a
sklearnspecific plugin that dispatches tosklearnclone, ensuring that configs get cloned as well.An approach to sktime/sktime#7333, which would be solved directly after update.
An alternative to #380, with advantages:
sklearncompatibility is automatic, for any dependency ofskbasedictsupportA test for sktime/sktime#7333, namely that output configs are retained in
sklearnobjects, has been added.