Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Put PlantUML indentation level in plantuml customization group #169

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Put PlantUML indentation level in plantuml customization group #169

wants to merge 2 commits into from

Conversation

timcharper
Copy link

customize-group plantuml didn't include this setting in the list, and it seems appropriate to include it.

grtcdr
grtcdr approved these changes Nov 16, 2023
View reviewed changes
Copy link

@grtcdr grtcdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was about to make a pull request for this after I'd noticed a warning about a missing type keyword. However, I'd argue natnum is better than integer in this specific situation.

timcharper
timcharper commented Nov 22, 2023
View reviewed changes
plantuml-mode.el Outdated Show resolved Hide resolved
@grtcdr
Copy link

grtcdr commented Nov 24, 2023

Thanks for making that change! It's just unfortunate that this package seems to be in a sort of deserted state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grtcdr grtcdr grtcdr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timcharper @grtcdr