-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ipynb examples #339
Ipynb examples #339
Conversation
Why are tests for power spectrum included here? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks very good! Great job, Ian.
Two small changes:
- Add
plt.show()
to avoid outputing unnecesary text - Name of the config file for merger rates
- I still see
test_camb.py
andtest_class.py
.
I think you can add a semicolon at the end of a statement |
That works too, thanks @jucordero!
|
"\n", | ||
"Running the `merger_rates` example:\n", | ||
"```bash\n", | ||
"$ skypy merger_rates.yml --format fits\n", |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the intention that the user would run these notebooks themselves? I think they make more sense as part of the documentation (perhaps using nbsphinx?) but if that is the case they should probably be in the docs
directory not the examples
directory. Particularly because everything in examples
is mirrored to the skypyproject/examples
repository and we shouldn't distribute them in this way if we don't expect the user to run them.
The idea is to have something similar to CAMB DEMO |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These look good, let's merge them as they are and work out how we want to incorporate them with the documentation in the future.
Description
Merging will close #335. Have added iPython notebooks making plots from the outputs of the current example config files.
Checklist