perf(skymp5-server): implement parallel movement processing #2132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to 24dcf21 in 29 seconds
More details
- Looked at
189lines of code in3files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_FlHsm0RBS53WFKGO
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
⌛ 19 hours left in your free trial, upgrade for $20/seat/month or contact us.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Implemented parallel movement processing in
skymp5-serverusing a thread pool for improved performance.Key points:
skymp5-server.BS::thread_pooltoActionListenerfor concurrent processing.ActionListener::SendToNeighboursto handle deferred messages.ActionListener::TickDeferredSendToNeighboursMultithreadedfor multithreaded processing.PartOne::Tickto callTickDeferredSendToNeighboursMultithreaded.skymp5-server/cpp/server_guest_lib/ActionListener.cpp,ActionListener.h, andPartOne.cpp.Generated with ❤️ by ellipsis.dev