Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(skymp5-server): add server slot id to login logs #2300

Merged
merged 3 commits into from
Jan 31, 2025

Conversation

nic11
Copy link
Collaborator

@nic11 nic11 commented Jan 31, 2025

Important

Adds server slot ID to login logs in login.ts for better traceability in Discord messages.

  • Logging:
    • Adds Server Slot ${userId} to login logs in login.ts to include server slot ID in Discord messages.

This description was created by Ellipsis for b54e91b. It will automatically update as commits are pushed.

@nic11 nic11 changed the title [to master] add server slot id to login logs feat(skymp5-server): add server slot id to login logs Jan 31, 2025
@nic11 nic11 marked this pull request as ready for review January 31, 2025 17:08
Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to b54e91b in 8 seconds

More details
  • Looked at 13 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. skymp5-server/ts/systems/login.ts:185
  • Draft comment:
    Ensure that userId is indeed the server slot ID and is correctly used in this context. If userId is not the server slot ID, this log entry might be misleading.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The PR adds a new log entry for server slot ID in the login logs. This change is straightforward and seems to be correctly implemented. However, I need to ensure that the userId is indeed the server slot ID and that it is correctly used in the context of the logging function.

Workflow ID: wflow_InyH1BkrCz8OvZmf


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@nic11 nic11 merged commit 569371b into skyrim-multiplayer:main Jan 31, 2025
13 checks passed
@nic11 nic11 deleted the add-slot-to-login branch January 31, 2025 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant