feat(skymp5-client): update loadOrderVerificationService.ts

[Pospelove]

Important

getServerMods() in loadOrderVerificationService.ts now uses a hardcoded URL for server mods retrieval, with TODOs to unhardcode it.

• Behavior:
  • getServerMods() in loadOrderVerificationService.ts now uses a hardcoded URL https://gateway.skymp.net/api/servers/sweetpie/manifest.json instead of constructing it from targetIp and uiPort.
  • Adds TODO comments to unhardcode the master address and serverId.
• Misc:
  • Removes usage of getServerIp() and getServerUiPort() in getServerMods() function.

^{This description was created by for 9b8b37b. It will automatically update as commits are pushed.}

[ellipsis-dev]

❌ Changes requested. Reviewed everything up to 9b8b37b in 1 minute and 10 seconds

More details

• Looked at 18 lines of code in 1 files
• Skipped 0 files when reviewing.
• Skipped posting 2 drafted comments based on config settings.

1. skymp5-client/src/services/services/loadOrderVerificationService.ts:112

• Draft comment:
  Beware: The base URL already ends with 'manifest.json', so using .get('/manifest.json') might append it twice.
• Reason this comment was not posted:
  Marked as duplicate.

2. skymp5-client/src/services/services/loadOrderVerificationService.ts:112

• Draft comment:
  TODO left: unhardcode master address and serverId ('sweetpie'). Consider parameterizing or configuring these values.
• Reason this comment was not posted:
  Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 10% vs. threshold = 50%
  The comment is about changed code, as this section was modified to use a hardcoded URL instead of constructing it from targetIp and uiPort. However, the code already has TODO comments marking these issues. The automated comment just restates what's already marked and doesn't provide additional actionable information beyond suggesting "parameterizing or configuring" which is obvious.
  The comment does make a constructive suggestion about parameterizing the values. Maybe this additional suggestion makes it worth keeping?
  The suggestion to parameterize is obvious and implicit in the TODO comments. Anyone addressing the TODOs would naturally consider configuration/parameterization as the solution.
  The comment should be deleted as it's redundant with the TODO comments already in the code and doesn't provide additional actionable value.

Workflow ID: wflow_edczSyUEj5f67peE

---

Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[ellipsis-dev]

Using a full URL ending with 'manifest.json' and then calling .get('/manifest.json') can cause path duplication.