feat(skyrim-platform): revert "temporary duplicate dlls in root folder"

[nic11]

Reverts #2316

---

Important

Reverts duplicate DLL handling in index.js and updates DistContentsExpected.json to remove fmt.dll and spdlog.dll from the client directory.

• Behavior:
  • Reverts handling of requiredVcpkgDllsRoot in index.js, removing duplication of fmt.dll and spdlog.dll in the root folder.
• Distribution:
  • Updates DistContentsExpected.json to remove fmt.dll and spdlog.dll from the client directory.

^{This description was created by for 81fe7b8. It will automatically update as commits are pushed.}

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to 81fe7b8 in 26 seconds

More details

• Looked at 43 lines of code in 2 files
• Skipped 0 files when reviewing.
• Skipped posting 4 drafted comments based on config settings.

1. skyrim-platform/tools/dev_service/index.js:7

• Draft comment:
  Removal of duplicate DLL copy for fmt.dll and spdlog.dll; ensure that spdlog.dll is correctly deployed elsewhere if needed.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

2. unit/DistContentsExpected.json:332

• Draft comment:
  Updated expected files: removed client/fmt.dll and client/spdlog.dll to match reverted behavior.
• Reason this comment was not posted:
  Comment did not seem useful. Confidence is useful = 0% <= threshold 50%
  This comment is purely informative, stating that some files were removed to match reverted behavior. It doesn't provide any actionable feedback or suggestions for improvement.

3. skyrim-platform/tools/dev_service/index.js:7

• Draft comment:
  Ensure removal of duplicate DLL copies (fmt.dll and spdlog.dll) is intentional and won’t break dependency resolution.
• Reason this comment was not posted:
  Confidence changes required: 0% <= threshold 50%
  None

4. unit/DistContentsExpected.json:332

• Draft comment:
  Test expectations updated: confirm that removal of 'client/fmt.dll' and 'client/spdlog.dll' from root is correct.
• Reason this comment was not posted:
  Confidence changes required: 0% <= threshold 50%
  None

Workflow ID: wflow_kuJtfBRMQuQegZ1Q

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.