feat(skymp5-client): revert manual host resolution

[nic11]

Important

Removes manual DNS resolution in skympClient.ts, using server-ip directly for connections.

• Behavior:
  • Removes manual DNS resolution logic in skympClient.ts.
  • Directly uses server-ip from settings for connection.
• Functions:
  • Deletes resolveHost() function in SkympClient class.
  • Updates establishConnectionConditional() to use targetIp directly.

^{This description was created by for 81b6db1. It will automatically update as commits are pushed.}

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to 81b6db1 in 33 seconds

More details

• Looked at 42 lines of code in 1 files
• Skipped 0 files when reviewing.
• Skipped posting 5 drafted comments based on config settings.

1. skymp5-client/src/services/services/skympClient.ts:1

• Draft comment:
  Removal of DNS resolution: The manual host resolution function and its dependencies (resolve4, promisify) were removed, which is acceptable given the config now uses an IP directly.
• Reason this comment was not posted:
  Confidence changes required: 0% <= threshold 50%
  None

2. skymp5-client/src/services/services/skympClient.ts:93

• Draft comment:
  Direct usage of targetIp from settings is clear and concise. Ensure that the configuration 'server-ip' is validated externally as this change bypasses DNS resolution.
• Reason this comment was not posted:
  Confidence changes required: 0% <= threshold 50%
  None

3. skymp5-client/src/services/services/skympClient.ts:14

• Draft comment:
  Removed manual DNS resolution via 'resolve4' and 'promisify'. Ensure the 'server-ip' setting always provides a valid IP.
• Reason this comment was not posted:
  Confidence changes required: 0% <= threshold 50%
  None

4. skymp5-client/src/services/services/skympClient.ts:20

• Draft comment:
  Changed config key from 'server-host' to 'server-ip'. Confirm that the configuration and docs reflect this change.
• Reason this comment was not posted:
  Confidence changes required: 0% <= threshold 50%
  None

5. skymp5-client/src/services/services/skympClient.ts:89

• Draft comment:
  The 'establishConnectionConditional' method is marked async but no awaits are used now. Consider removing async or adding error handling if needed.
• Reason this comment was not posted:
  Confidence changes required: 33% <= threshold 50%
  None

Workflow ID: wflow_VlQylLRR7pHcVYcN

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.