feat(skymp5-server): implement rest of Utility functions

[Wedmer]

Important

Implement additional utility functions in PapyrusUtility for waiting, game time, and array operations, with helper methods for refactoring.

• Behavior:
  • Refactor Wait() in PapyrusUtility.cpp to use WaitHelper().
  • Add WaitMenuMode(), WaitGameTime(), IsInMenuMode(), GetCurrentGameTime(), GameTimeToString() to PapyrusUtility.cpp.
  • Add array creation and resizing functions: CreateAliasArray(), CreateBoolArray(), CreateFloatArray(), CreateFormArray(), CreateIntArray(), ResizeAliasArray(), ResizeBoolArray(), ResizeFloatArray(), ResizeFormArray(), ResizeIntArray().
• Helpers:
  • Introduce WaitHelper() and ArrayHelper() in PapyrusUtility.cpp for handling wait and array operations.
• Registration:
  • Register new functions in Register() method in PapyrusUtility.cpp.

^{This description was created by for c85bbad. It will automatically update as commits are pushed.}

[ellipsis-dev]

❌ Changes requested. Reviewed everything up to c85bbad in 2 minutes and 34 seconds

More details

• Looked at 267 lines of code in 2 files
• Skipped 0 files when reviewing.
• Skipped posting 5 drafted comments based on config settings.

1. skymp5-server/cpp/server_guest_lib/script_classes/PapyrusUtility.cpp:203

• Draft comment:
  Capturing the promise by value in the lambda may break resolution. Consider capturing by reference or using move semantics.
• Reason this comment was not posted:
  Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 10% vs. threshold = 50%
  Promise objects often need careful handling with regards to ownership and lifetime. However, without seeing the implementation of Promise, VarValue, and how they handle copying/moving, it's hard to be certain if value capture is problematic here. The code was just moved to a helper function but the core logic remains unchanged.
  I don't have visibility into the Promise implementation to know if value capture is actually problematic. The code may work perfectly fine as is.
  Without clear evidence that value capture is causing issues, and without being able to see the Promise implementation, this comment is too speculative.
  Delete the comment since we don't have strong evidence that value capture is problematic, and the suggestion is speculative without understanding the Promise implementation details.

2. skymp5-server/cpp/server_guest_lib/script_classes/PapyrusUtility.h:10

• Draft comment:
  Fix typos in parameter names ('slef' should be 'self').
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

3. skymp5-server/cpp/server_guest_lib/script_classes/PapyrusUtility.cpp:203

• Draft comment:
  Lambda in WaitHelper captures resultPromise by value and calls non-const methods (Resolve/Reject). Mark the lambda as mutable or capture resultPromise by reference to ensure these calls compile.
• Reason this comment was not posted:
  Marked as duplicate.

4. skymp5-server/cpp/server_guest_lib/script_classes/PapyrusUtility.cpp:215

• Draft comment:
  The argument count check in ArrayHelper is incorrect. For non-resize calls, two arguments are required (size and fill value), and for resize calls, three arguments are needed. Update the condition accordingly.
• Reason this comment was not posted:
  Marked as duplicate.

5. skymp5-server/cpp/server_guest_lib/script_classes/PapyrusUtility.cpp:219

• Draft comment:
  Consider using static_cast<size_t> for arraySize instead of static_cast<int32_t> to match the variable type and avoid potential sign issues.
• Reason this comment was not posted:
  Confidence changes required: 33% <= threshold 50%
  None

Workflow ID: wflow_JfpymfZrppQoYoK0

---

Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[Wedmer]

Implementation for INI, Budget, Memory functions wasn't added as I can't imagine any use of them.

[nic11]

Let's see it on the test server

[Pospelove]

Looks safe and correct. We can merge it after morning update I guess