Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(skymp5-client): update URL for updateRequired event in authService.ts #2334

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

Pospelove
Copy link
Contributor

@Pospelove Pospelove commented Feb 11, 2025

Important

Update URL for events.updateRequired in authService.ts to https://skymp.net/UpdInstall.

  • Behavior:
    • Update URL in onBrowserMessage function in authService.ts for events.updateRequired from https://skymp.net/AlternativeDownload to https://skymp.net/UpdInstall.

This description was created by Ellipsis for 32fa595. It will automatically update as commits are pushed.

@ellipsis-dev ellipsis-dev bot changed the title . fix: update URL for updateRequired event in authService.ts Feb 11, 2025
@Pospelove Pospelove changed the title fix: update URL for updateRequired event in authService.ts fix(skymp5-client): update URL for updateRequired event in authService.ts Feb 11, 2025
Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 32fa595 in 42 seconds

More details
  • Looked at 13 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. skymp5-client/src/services/services/authService.ts:231
  • Draft comment:
    Confirm the new update URL is correct; the change from /AlternativeDownload to /UpdInstall may have implications.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50%
    The comment is asking the author to confirm the correctness of a URL change, which is not allowed by the rules. It doesn't provide a specific suggestion or point out a clear issue with the change.
2. skymp5-client/src/services/services/authService.ts:230
  • Draft comment:
    Changed update URL to 'https://skymp.net/UpdInstall'. Ensure this new URL is correct and all related references are updated.
  • Reason this comment was not posted:
    Marked as duplicate.

Workflow ID: wflow_tagx2nhhIiqf9323


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@Pospelove Pospelove merged commit c39d486 into skyrim-multiplayer:main Feb 11, 2025
10 of 16 checks passed
@Pospelove Pospelove deleted the url branch February 11, 2025 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant