Implement multipleOf #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test failures are introduced in hhvm 4.0. I'll use alternatives that do work. |
HHVM 4.0 does not allow reading from unknown fields using `??` This was acutally a correct check This saves us from the bug where someone does `"multipleOf": "cow"`
mwildehahn
reviewed
Feb 4, 2020
| $remainer = Math\abs( | ||
| $dividend is int && $devisor is int ? $dividend % $devisor : \fmod((float)$dividend, (float)$devisor), | ||
| ); | ||
| \var_dump(dict[ |
There was a problem hiding this comment.
Not sure if you're still working on this, but we'll want to take this out
There was a problem hiding this comment.
The var_dump() was for debugging purposes.
Will be I'll remove it.
| use namespace HH\Lib\Math; | ||
| use namespace Slack\Hack\JsonSchema; | ||
|
|
||
| const float COMPARISON_LEEWAY = 10. ** -6; |
| throw new JsonSchema\InvalidFieldException($pointer, vec[$error]); | ||
| } | ||
| if ($remainer is float) { | ||
| if ($remainer < $devisor / 2 && $remainer > COMPARISON_LEEWAY) { |
There was a problem hiding this comment.
Would be good to have a comment about this logic.
There was a problem hiding this comment.
Yeah, that is a good plan.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To quote John F. Kennedy
Partially addresses #7