fix(happy-app): add error boundaries to contain render crashes#847
Open
EricSeastrand wants to merge 3 commits intoslopus:mainfrom
Open
fix(happy-app): add error boundaries to contain render crashes#847EricSeastrand wants to merge 3 commits intoslopus:mainfrom
EricSeastrand wants to merge 3 commits intoslopus:mainfrom
Conversation
Add two layers of error boundaries to prevent a single component crash from locking up the entire app: - Session-level: wraps chat content so header/back button stay functional when a chat crashes, letting users navigate away - Widget-level: wraps each tool view (TodoView, EditView, etc.) so a broken widget shows an inline error instead of crashing the whole chat Generated with [Claude Code](https://claude.ai/code) via [Happy](https://happy.engineering) Co-Authored-By: Claude <noreply@anthropic.com> Co-Authored-By: Happy <yesreply@happy.engineering>
Two fixes: 1. session.todos.filter crash: Claude Code sometimes sends TodoWrite's todos param as a JSON string instead of an array. Added parseTodos() in the reducer to handle string-encoded arrays, and Array.isArray() guard in ActiveSessionsGroup to prevent render crashes. 2. Error boundary gaps: The existing boundaries only protected tool views and chat content. The home screen sessions list had zero coverage — one bad session crashed the entire app. Added boundaries around each session card in ActiveSessionsGroup, ActiveSessionsGroupCompact, and SessionsList so a single broken session shows an inline error instead of the full-screen "Something went wrong" overlay. Generated with [Claude Code](https://claude.ai/code) via [Happy](https://happy.engineering) Co-Authored-By: Claude <noreply@anthropic.com> Co-Authored-By: Happy <yesreply@happy.engineering>
Wrap each message in ChatList with an ErrorBoundary so a single malformed message shows an inline error instead of crashing the entire chat. Wrap each tab content (Sessions, Inbox, Settings) in MainView so a crash in one tab doesn't kill the home screen. Generated with [Claude Code](https://claude.ai/code) via [Happy](https://happy.engineering) Co-Authored-By: Claude <noreply@anthropic.com> Co-Authored-By: Happy <yesreply@happy.engineering>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ErrorBoundarycomponent with two granularity levels: session-wide (chat view) and widget-level (individual tool views)Test plan
🤖 Generated with Claude Code
via Happy