Skip to content

fix(happy-app): include server error details in RPC failure messages #848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
EricSeastrand wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(happy-app): include server error details in RPC failure messages #848

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/happy-app/sources/sync/apiSocket.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ class ApiSocket {
if (result.ok) {
return await sessionEncryption.decryptRaw(result.result) as R;
}
throw new Error('RPC call failed');
throw new Error(`RPC call failed: ${result.error || 'unknown error'}`);
}

/**
Expand All @@ -145,7 +145,7 @@ class ApiSocket {
if (result.ok) {
return await machineEncryption.decryptRaw(result.result) as R;
}
throw new Error('RPC call failed');
throw new Error(`RPC call failed: ${result.error || 'unknown error'}`);
}

send(event: string, data: any) {
Expand Down