fix(happy-coder): return raw Codex approval decisions#863
Open
0809android wants to merge 1 commit intoslopus:mainfrom
Open
fix(happy-coder): return raw Codex approval decisions#8630809android wants to merge 1 commit intoslopus:mainfrom
0809android wants to merge 1 commit intoslopus:mainfrom
Conversation
18cf95e to
685e3fd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
elicitation/createmethod instead ofsetRequestHandler(ElicitRequestSchema, ...){ decision }shape thatcodex mcp-serverexpectsapproved_for_sessiontoapprovedand reject unsupported / incomplete requests withabortWhy
I was reproducing the Android permission flow issue from #229 with Codex sessions.
In practice,
codex mcp-servercurrently expects a non-standard top-level approval response like:{ "decision": "approved" }Using the MCP SDK's standard elicitation handler path returns the SDK-shaped payload instead, which causes Codex to reject the approval response and the command stays stuck or ends up rejected after approval.
This patch keeps the existing Happy permission flow, but installs the Codex approval handler on the raw request map so the response shape matches what Codex actually consumes today.
Testing
PATH=/Users/kinocode/.nvm/versions/node/v22.19.0/bin:$PATH yarn installPATH=/Users/kinocode/.nvm/versions/node/v22.19.0/bin:$PATH yarn workspace happy-coder buildPATH=/Users/kinocode/.nvm/versions/node/v22.19.0/bin:$PATH ./node_modules/.bin/vitest run packages/happy-cli/src/codex/__tests__/codexMcpClient.test.tscodex mcp-server 0.106.0{ action, content }approval responses failed withmissing field decision{ decision: "approved" }resumed the command successfully{ decision: "abort" }produced the expectedrejected by user